From issues-return-5460-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Sat Mar 23 20:36:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 68594180600 for ; Sat, 23 Mar 2019 21:36:02 +0100 (CET) Received: (qmail 44274 invoked by uid 500); 23 Mar 2019 20:36:01 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 44264 invoked by uid 99); 23 Mar 2019 20:36:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Mar 2019 20:36:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DD097E0D42 for ; Sat, 23 Mar 2019 20:36:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5D21624597 for ; Sat, 23 Mar 2019 20:36:00 +0000 (UTC) Date: Sat, 23 Mar 2019 20:36:00 +0000 (UTC) From: "Thomas D'Silva (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4910) Improvements to spooled MappedByteBufferQueue files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4910?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 799788#comment-16799788 ]=20 Thomas D'Silva commented on PHOENIX-4910: ----------------------------------------- [~elserj] In PHOENIX-5131 [~abhishek.chouhan] providing an option to make s= pooling configurable. You will have to rebase your patch. > Improvements to spooled MappedByteBufferQueue files > --------------------------------------------------- > > Key: PHOENIX-4910 > URL: https://issues.apache.org/jira/browse/PHOENIX-4910 > Project: Phoenix > Issue Type: Bug > Reporter: Josh Elser > Assignee: Josh Elser > Priority: Major > Fix For: 4.15.0, 5.1.0 > > Attachments: PHOENIX-4910.001.patch, PHOENIX-4910.002.patch > > > A user ran into a JVM bug which appears to have caused a RegionServer to = crash while running a topN aggregate query. This left a large number of fil= es in {{/tmp}} after the RS had gone away (due to a JVM SIGBUS crash). Mapp= edByteBufferQueue will buffer results in memory up to 20MB by default (cont= rolled by=C2=A0{{phoenix.query.spoolThresholdBytes}}) and then start append= ing them to a file. I'm seeing two things which could be improved: > * If the RS exits abnormally, there is no process to clean up files - wo= uld be nice to register the {{deleteOnExit()}} hook to try to clean these u= p. > * There is no ability to control where MappedByteBufferQueue writes its = spool file - would be nice to use something other than /tmp (I think we hav= e a property to control this already in our config..) > FYI [~ankit@apache.org] -- This message was sent by Atlassian JIRA (v7.6.3#76005)