From issues-return-5505-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue Mar 26 20:12:32 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D8F4B180627 for ; Tue, 26 Mar 2019 21:12:31 +0100 (CET) Received: (qmail 41064 invoked by uid 500); 26 Mar 2019 20:12:31 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 41054 invoked by uid 99); 26 Mar 2019 20:12:31 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Mar 2019 20:12:31 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] gokceni commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables Message-ID: <155363115050.5592.10356480627627853203.gitbox@gitbox.apache.org> Date: Tue, 26 Mar 2019 20:12:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit gokceni commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables URL: https://github.com/apache/phoenix/pull/469#discussion_r269294461 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/HashJoinRegionScanner.java ########## @@ -74,18 +75,18 @@ private final boolean addArrayCell; @SuppressWarnings("unchecked") - public HashJoinRegionScanner(RegionScanner scanner, TupleProjector projector, + public HashJoinRegionScanner(RegionScanner scanner, Scan scan, TupleProjector projector, HashJoinInfo joinInfo, ImmutableBytesPtr tenantId, RegionCoprocessorEnvironment env, boolean useQualifierAsIndex, boolean useNewValueColumnQualifier) throws IOException { - this(env, scanner, null, null, projector, joinInfo, + this(env, scanner, scan,null, null, projector, joinInfo, tenantId, useQualifierAsIndex, useNewValueColumnQualifier); } @SuppressWarnings("unchecked") - public HashJoinRegionScanner(RegionCoprocessorEnvironment env, RegionScanner scanner, + public HashJoinRegionScanner(RegionCoprocessorEnvironment env, RegionScanner scanner, Scan scan, final Set arrayKVRefs, Review comment: Is Scan parameter used anywhere? I could not find where you are using this one? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services