From issues-return-5368-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Mon Mar 18 21:40:57 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DC6B21807CD for ; Mon, 18 Mar 2019 22:40:54 +0100 (CET) Received: (qmail 65917 invoked by uid 500); 18 Mar 2019 21:40:54 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 65897 invoked by uid 99); 18 Mar 2019 21:40:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Mar 2019 21:40:53 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] gjacoby126 commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables Message-ID: <155294525337.24533.16118003383868748648.gitbox@gitbox.apache.org> Date: Mon, 18 Mar 2019 21:40:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit gjacoby126 commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables URL: https://github.com/apache/phoenix/pull/469#discussion_r266651973 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/RegionScannerFactory.java ########## @@ -169,7 +177,13 @@ public long getMvccReadPoint() { @Override public boolean nextRaw(List result) throws IOException { try { - boolean next = s.nextRaw(result); + boolean next; + do { Review comment: This little bit of loop code gets repeated in several places -- any way to encapsulate it somewhere that can be reused? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services