From issues-return-5186-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Mar 15 02:20:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 75D46180785 for ; Fri, 15 Mar 2019 03:20:07 +0100 (CET) Received: (qmail 99209 invoked by uid 500); 15 Mar 2019 02:20:06 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 99108 invoked by uid 99); 15 Mar 2019 02:20:06 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Mar 2019 02:20:06 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] BinShi-SecularBird commented on a change in pull request #463: Phoenix stats Initial Commit Message-ID: <155261640566.25543.16618037783343712461.gitbox@gitbox.apache.org> Date: Fri, 15 Mar 2019 02:20:05 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit BinShi-SecularBird commented on a change in pull request #463: Phoenix stats Initial Commit URL: https://github.com/apache/phoenix/pull/463#discussion_r265805513 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ########## @@ -694,4 +694,138 @@ public TimeRange getRowTimestampRange() { return rowTimestampRange; } + public List getRowKeyRanges(){ + + //If its scanRanges are everything or nothing we short circuit and leave + //As schema is not filled in + if (this.equals(ScanRanges.EVERYTHING)) { + return Lists.newArrayList(KeyRange.EVERYTHING_RANGE); + } + if (this.equals(ScanRanges.NOTHING)) { Review comment: Could you use this.isDegenerate()? It is an existing helper function seems much cheaper. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services