From issues-return-5146-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Mar 14 18:58:00 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A4427180763 for ; Thu, 14 Mar 2019 19:57:59 +0100 (CET) Received: (qmail 92136 invoked by uid 500); 14 Mar 2019 18:57:53 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 91988 invoked by uid 99); 14 Mar 2019 18:57:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Mar 2019 18:57:53 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] gjacoby126 commented on a change in pull request #457: PHOENIX-5190 Implement TaskRegionObserver for Index rebuild Message-ID: <155258987322.20117.8931370497009080919.gitbox@gitbox.apache.org> Date: Thu, 14 Mar 2019 18:57:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit gjacoby126 commented on a change in pull request #457: PHOENIX-5190 Implement TaskRegionObserver for Index rebuild URL: https://github.com/apache/phoenix/pull/457#discussion_r265721113 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ########## @@ -3521,6 +3524,31 @@ public void upgradeSystemTables(final String url, final Properties props) throws clearCache(); } } + + try { + metaConnection.createStatement().executeUpdate(getTaskDDL()); + } catch (NewerTableAlreadyExistsException e) { + + } catch (TableAlreadyExistsException e) { + long currentServerSideTableTimeStamp = e.getTable().getTimeStamp(); + if (currentServerSideTableTimeStamp <= MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP_5_1_0) { Review comment: Keep in mind this change will also likely go into 4.15, so the upgrade will need to happen for either 4.15 or 5.1 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services