From issues-return-5117-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Mar 14 03:47:09 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7798A180763 for ; Thu, 14 Mar 2019 04:47:08 +0100 (CET) Received: (qmail 40582 invoked by uid 500); 14 Mar 2019 03:47:07 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 40556 invoked by uid 99); 14 Mar 2019 03:47:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Mar 2019 03:47:07 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] comnetwork commented on a change in pull request #444: PHOENIX-5148 Message-ID: <155253522659.30631.13082893549650416937.gitbox@gitbox.apache.org> Date: Thu, 14 Mar 2019 03:47:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit comnetwork commented on a change in pull request #444: PHOENIX-5148 URL: https://github.com/apache/phoenix/pull/444#discussion_r265411058 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/execute/AggregatePlan.java ########## @@ -327,4 +333,15 @@ public boolean useRoundRobinIterator() throws SQLException { return visitor.visit(this); } + private static OrderBy convertActualOutputOrderBy(OrderBy orderBy, GroupBy groupBy, StatementContext statementContext) { Review comment: Not every plan have to implement this function, eg. HashJoinPlan and SortMergeJoinPlan. In my opinion, this method is not suitable to declared as abstract method in QueryPlan and subclass to override it , because this method is to invoke in the ctor of concrete subclass. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services