From issues-return-5045-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue Mar 12 00:47:45 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 30411180763 for ; Tue, 12 Mar 2019 01:47:45 +0100 (CET) Received: (qmail 71425 invoked by uid 500); 12 Mar 2019 00:47:44 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 71411 invoked by uid 99); 12 Mar 2019 00:47:44 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Mar 2019 00:47:44 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] [phoenix] vincentpoon commented on a change in pull request #462: PHOENIX-2787 support IF EXISTS for ALTER TABLE SET options Message-ID: <155235166360.29613.14573662781643753477.gitbox@gitbox.apache.org> Date: Tue, 12 Mar 2019 00:47:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vincentpoon commented on a change in pull request #462: PHOENIX-2787 support IF EXISTS for ALTER TABLE SET options URL: https://github.com/apache/phoenix/pull/462#discussion_r264484667 ########## File path: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java ########## @@ -430,6 +430,10 @@ public Integer call() throws SQLException { return executeMutation(stmt, false); } } + if (stmt instanceof ExecutableAddColumnStatement && + ((ExecutableAddColumnStatement) stmt).ifSetOptionExists()) { + return 0; Review comment: Why do we need this in this catching of exception? We shouldn't need this here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services