phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhishek Singh Chouhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5219) Fix ConcurrentMutationsIT testLockUntilMVCCAdvanced and testRowLockDuringPreBatchMutateWhenIndexed failures on the master branch
Date Fri, 29 Mar 2019 21:09:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805443#comment-16805443
] 

Abhishek Singh Chouhan commented on PHOENIX-5219:
-------------------------------------------------

[~tdsilva] Since CellUtil#setTimeStamp is deprecated, i think it might be a good idea to weigh
in on what are the utils CPs(Phoenix) need in general that should be provided by HBase. Over
at [HBASE-18995|https://jira.apache.org/jira/browse/HBASE-18995] there's a discussion of
having a separate Util for coprocessors, since many of the CellUtil functions have moved to
PrivateCellUtil which is IA.Private.

> Fix ConcurrentMutationsIT testLockUntilMVCCAdvanced and testRowLockDuringPreBatchMutateWhenIndexed
failures on the master branch
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5219
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5219
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>            Priority: Major
>             Fix For: 5.1.0
>
>         Attachments: PHOENIX-5219.patch
>
>
> These tests are failing because when we set the timestamp in {{Indexer.preBatchMutateWithExceptions}}
we call {{KeyValueUtil.ensureKeyValues}} on the list of cells and then call {{KeyValue.getTimestampOffset}}
> Pre 2.0 the cells objects are NoTagsKeyValue (which extend KeyValue). In 2.0 they are
NoTagsByteBufferKeyValue (which doesn't extend KeyValue) so {{KeyValueUtil.ensureKeyValues}}
returns a new list of objects on which we set the timestamp. 
> The fix us to use  {{CellUtil.setTimestamp}} to the set the timestamp directly on the
cell. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message