phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Swaroopa Kadam (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5204) Breaking UpsertCompiler#compile function into small readable functions
Date Wed, 20 Mar 2019 23:08:01 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797639#comment-16797639
] 

Swaroopa Kadam commented on PHOENIX-5204:
-----------------------------------------

Thank you very much for your input [~gjacoby] I was initially considering to break the UpsertCompiler
class but it would be at even coarser level. I'lI will start by analyzing test coverage
for UpsertCompiler.compile method. Thanks! 

 

> Breaking UpsertCompiler#compile function into small readable functions
> ----------------------------------------------------------------------
>
>                 Key: PHOENIX-5204
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5204
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.14.1
>            Reporter: Swaroopa Kadam
>            Assignee: Swaroopa Kadam
>            Priority: Minor
>
> Currently, UpsertCompile#compile method is ~500 lines and does multiple things listed
below:
>  # Upsert Select
>  # Upsert Select (Client/Server side)
>  # Upsert Values
> It would be better and cleaner to break the method into logically smaller and more readable
methods. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message