phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5187) Avoid using FileInputStream and FileOutputStream
Date Mon, 11 Mar 2019 20:51:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789953#comment-16789953
] 

Hadoop QA commented on PHOENIX-5187:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12962013/PHOENIX-5187-4.x-HBase-1.3.patch
  against 4.x-HBase-1.3 branch at commit 26d3734d3c2a05c56e92a0ea09a99fd90059f568.
  ATTACHMENT ID: 12962013

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.trace.PhoenixTracingEndToEndIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NonColumnEncodedImmutableTxStatsCollectorIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2413//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2413//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2413//console

This message is automatically generated.

> Avoid using FileInputStream and FileOutputStream 
> -------------------------------------------------
>
>                 Key: PHOENIX-5187
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5187
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.14.1
>            Reporter: Aman Poonia
>            Assignee: Aman Poonia
>            Priority: Major
>         Attachments: PHOENIX-5187-4.x-HBase-1.3.patch
>
>
> Avoid using FileInputStream and FileOutputStream because of
> [https://bugs.openjdk.java.net/browse/JDK-8080225]
> The file objects doesnot get cleaned up even if we close it until full GC happens
> This has been resolved in jdk10
> A quick workaround is to use File.newInputStream and Files.newOutputStream



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message