phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chinmay Kulkarni (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5186) Remove redundant check for local in metadata client
Date Sat, 16 Mar 2019 00:07:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794050#comment-16794050
] 

Chinmay Kulkarni commented on PHOENIX-5186:
-------------------------------------------

[~mnpoonia] change lgtm, but looks like the patch failed to apply. Please generate a patch
using _git format-patch_

> Remove redundant check for local in metadata client
> ---------------------------------------------------
>
>                 Key: PHOENIX-5186
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5186
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.14.1
>            Reporter: Aman Poonia
>            Assignee: Aman Poonia
>            Priority: Minor
>         Attachments: PHOENIX-5186.4.x-HBase-1.3.patch
>
>
> Remove redundant check for local index type in metadata client
> {code:java}
> if (index.getIndexType() != IndexType.LOCAL) {
>     if (index.getIndexType() != IndexType.LOCAL) {
>         if (table.getType() != PTableType.VIEW) {
>             rowCount += updateStatisticsInternal(index.getPhysicalName(), index,
>                     updateStatisticsStmt.getProps(), true);
>         } else {
>             rowCount += updateStatisticsInternal(table.getPhysicalName(), index,
>                     updateStatisticsStmt.getProps(), true);
>         }
>     }
> }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message