phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5182) Deprecate getTotalSum API of the GlobalMetric interface
Date Sat, 09 Mar 2019 07:47:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788565#comment-16788565
] 

Hudson commented on PHOENIX-5182:
---------------------------------

ABORTED: Integrated in Jenkins build Phoenix-4.x-HBase-1.4 #92 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.4/92/])
PHOENIX-5182: Deprecate getTotalSum API of the GlobalMetric interface (chinmayskulkarni: rev
eb3de54a9c6ea80de79d70f9968af01930fd4200)
* (edit) phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/execute/PartialCommitIT.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetric.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsDisabledIT.java


> Deprecate getTotalSum API of the GlobalMetric interface
> -------------------------------------------------------
>
>                 Key: PHOENIX-5182
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5182
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Chinmay Kulkarni
>            Assignee: Chinmay Kulkarni
>            Priority: Major
>             Fix For: 4.13.0, 4.14.0, 4.13.1, 5.0.0, 4.15.0, 4.14.1, 5.1.0
>
>         Attachments: PHOENIX-5182.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The GlobalMetric interface has a getTotalSum API which is not of much value. The only
implementation of this interface GlobalMetricImpl (which is not no-op) basically does a getValue
for the metric when we call getTotalSum, which is confusing. We should deprecate it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message