phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5180) Add API to PhoenixRunTime to get ptable of a tenant using a global connection
Date Sat, 16 Mar 2019 02:19:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794093#comment-16794093
] 

Hadoop QA commented on PHOENIX-5180:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12962661/PHOENIX-5180-master.patch
  against master branch at commit 05b99018a77805cd92411c26bd4147e62cbf7281.
  ATTACHMENT ID: 12962661

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                    "Expected TableNotFoundException for trying to get tenant specific
view without tenantid");
+    public MetaDataMutationResult updateCache(PName origTenantId, String schemaName, String
tableName,

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ChangePermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableDDLPermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2433//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2433//console

This message is automatically generated.

> Add API to PhoenixRunTime to get ptable of a tenant using a global connection
> -----------------------------------------------------------------------------
>
>                 Key: PHOENIX-5180
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5180
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Thomas D'Silva
>            Assignee: Abhishek Singh Chouhan
>            Priority: Major
>              Labels: SFDC
>         Attachments: PHOENIX-5180-master.patch
>
>
> If we want to look up the PTable of a tenant view we currently need to create a tenant
specific connection and call {{PhoenixRuntime.getTable()}}. This could be inefficient if we
need to create millions of tenant specific connections.
> We could instead just pass in the tenant id and use a global connection
>  {{getTable(Connection conn, String tenantId, String fullTableName, long timestamp)}}
> Insread of using the scn from the connection to set the clientTimestamp, we would use
the passed in timestamp.
> If the table isn't cached we would need to make a rpc to fetch the table from SYSTEM.CATALOG
> {code:java}
> MetaDataMutationResult result = new MetaDataClient(pconn).updateCache(PName tenantId,
String schemaName, String tableName)
> {code}
> FYI [~andrew.purtell@gmail.com]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message