phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-5175) Separate client settings for disabling server side mutations for upserts and deletes
Date Tue, 05 Mar 2019 22:10:00 GMT


Hadoop QA commented on PHOENIX-5175:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit 6d13f5b70944f581a1b20a8ef48df0b84a6f2b6f.
  ATTACHMENT ID: 12961231

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +        props.setProperty(QueryServices.ENABLE_SERVER_SIDE_DELETE_MUTATIONS, allowServerSideMutations);
+        props.setProperty(QueryServices.ENABLE_SERVER_SIDE_UPSERT_MUTATIONS, allowServerSideMutations);
+    public static final String ENABLE_SERVER_SIDE_DELETE_MUTATIONS ="phoenix.client.enable.server.delete.mutations";
+    public static final String ENABLE_SERVER_SIDE_UPSERT_MUTATIONS ="phoenix.client.enable.server.upsert.mutations";

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Release audit warnings:
Console output:

This message is automatically generated.

> Separate client settings for disabling server side mutations for upserts and deletes
> ------------------------------------------------------------------------------------
>                 Key: PHOENIX-5175
>                 URL:
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>            Priority: Minor
>         Attachments: PHOENIX-5175-master-v2.patch, PHOENIX-5175-master.patch
> PHOENIX-5026 added setting to disable server side mutations for upserts AND deletes.
This is an addition to that and provides separate knobs for upserts and deletes.

This message was sent by Atlassian JIRA

View raw message