phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chinmay Kulkarni (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PHOENIX-5169) Query logger is still initialized for each query when the log level is off
Date Fri, 29 Mar 2019 21:04:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805440#comment-16805440
] 

Chinmay Kulkarni edited comment on PHOENIX-5169 at 3/29/19 9:03 PM:
--------------------------------------------------------------------

[~Jaanai] This patch is causing a compilation error for 4.x-HBase-1.3:

 

[ERROR] /Users/ckulkarni/os_phoenix/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryLoggerIT.java:[68,36]
package javax.validation.constraints does not exist
 [ERROR] /Users/ckulkarni/os_phoenix/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryLoggerIT.java:[69,36]
package javax.validation.constraints does not exist

I believe these imports have been added by mistake and are not being used. Can you please
put up an addendum patch and check for all branches? Good to also remove these imports from
master since they are unused


was (Author: ckulkarni):
[~Jaanai] This patch is causing a compilation error for 4.x-HBase-1.3:

 

[ERROR] /Users/ckulkarni/os_phoenix/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryLoggerIT.java:[68,36]
package javax.validation.constraints does not exist
[ERROR] /Users/ckulkarni/os_phoenix/phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryLoggerIT.java:[69,36]
package javax.validation.constraints does not exist

I believe these imports have been added by mistake and are not being used. Can you please
put up an addendum patch and check for all branches?

> Query logger is still initialized for each query when the log level is off
> --------------------------------------------------------------------------
>
>                 Key: PHOENIX-5169
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5169
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.0.0
>            Reporter: jaanai
>            Assignee: jaanai
>            Priority: Major
>             Fix For: 4.14.2, 5.1
>
>         Attachments: PHOENIX-5169-master-v2.patch, PHOENIX-5169-master-v3.patch, PHOENIX-5169-master-v4.patch,
PHOENIX-5169-master.patch, image-2019-02-28-10-05-00-518.png
>
>
> we will still invoke createQueryLogger in PhoenixStatement for each query when query
logger level is OFF, which has significant throughput impacts under multiple threads.
> The below is jstack with the concurrent query:
> !https://gw.alicdn.com/tfscom/TB1HC3bI4TpK1RjSZFMXXbG_VXa.png|width=500,height=400!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message