phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-5156) Consistent Global Indexes for Non-Transactional Tables
Date Thu, 21 Mar 2019 23:33:00 GMT


Hadoop QA commented on PHOENIX-5156:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit c06bb592ca489e41b7df11cab248135ad534416d.
  ATTACHMENT ID: 12963313

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +                assertEquals("Expected data table row count to match expected:<2>
but was:<1>", e.getMessage());
+                        new HashJoinRegionScanner(innerScanner, scan, p, j, ScanUtil.getTenantId(scan),
+            theScanner = new HashJoinRegionScanner(theScanner, scan, p, j, ScanUtil.getTenantId(scan),
env, useQualifierAsIndex, useNewValueColumnQualifier);
+          List<Pair<Mutation, byte[]>> indexUpdatesForDeletes = new ArrayList<>(indexUpdates.size());
+                      "preBatchMutateWithExceptions: indexMetaData is not an instance of
PhoenixIndexMetaData " +
+                              c.getEnvironment().getRegion().getRegionInfo().getTable().getNameAsString());
+          List<IndexMaintainer> maintainers = ((PhoenixIndexMetaData)indexMetaData).getIndexMaintainers();
+                  IndexMaintainer indexMaintainer = getIndexMaintainer(maintainers, next.getSecond());
+                                      c.getEnvironment().getRegion().getRegionInfo().getTable().getNameAsString());
+                          // For a delete mutation, first unverify the exiting row in the
index table and then delete

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Console output:

This message is automatically generated.

> Consistent Global Indexes for Non-Transactional Tables
> ------------------------------------------------------
>                 Key: PHOENIX-5156
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.13.0, 4.14.0, 5.0.0, 4.14.1
>            Reporter: Kadir OZDEMIR
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>         Attachments: PHOENIX-5156.master.001.patch, PHOENIX-5156.master.002.patch, PHOENIX-5156.master.003.patch
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
> Without transactional tables, the global indexes can get easily out of sync with their
data tables in Phoenix. Transactional tables require a separate transaction manager, have
some restrictions and performance penalties. This issue is to have consistent global indexes
without the need for using transactional tables.

This message was sent by Atlassian JIRA

View raw message