phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhishek Singh Chouhan (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-5131) Make spilling to disk for order/group by configurable
Date Thu, 14 Mar 2019 02:53:00 GMT


Abhishek Singh Chouhan commented on PHOENIX-5131:

Thanks for having a look [~ckulkarni]. Since the runtimeexception gets wrapped into a phoenixioexception,
i wanted the tests to test for the specific scenario of the queue becoming full and not result
in test passing for any other kind of phoenixioexception(different cause) both for server
and client side exception. Abstract queue's default add implementation calls offer which i'm
piggybacking on, my intention of overriding the add was just to give a more meaningful message
with the exception so the client gets a clear picture. I can however add a comment there if
it helps.

> Make spilling to disk for order/group by configurable
> -----------------------------------------------------
>                 Key: PHOENIX-5131
>                 URL:
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>         Attachments: PHOENIX-5131-4.x-HBase-1.4.patch, PHOENIX-5131-master-v2.patch,
PHOENIX-5131-master-v2.patch, PHOENIX-5131-master-v3.patch, PHOENIX-5131-master-v4.patch,
PHOENIX-5131-master.patch, PHOENIX-5131-master.patch
> We've observed that large queries, doing order/group by leading to issues on the regionserver
(crashes/long gc pauses/file handler exhaustion etc.). We should make spilling to disk configurable
and in case its disabled, fail the query once it hits the spilling limit on any of the region
servers. Also make spooling threshold server-side property only to prevent clients from controlling
memory allocation on the rs side.

This message was sent by Atlassian JIRA

View raw message