phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-4910) Improvements to spooled MappedByteBufferQueue files
Date Sat, 23 Mar 2019 20:47:00 GMT


Hadoop QA commented on PHOENIX-4910:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit c06bb592ca489e41b7df11cab248135ad534416d.
  ATTACHMENT ID: 12941125

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output:

This message is automatically generated.

> Improvements to spooled MappedByteBufferQueue files
> ---------------------------------------------------
>                 Key: PHOENIX-4910
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>         Attachments: PHOENIX-4910.001.patch, PHOENIX-4910.002.patch
> A user ran into a JVM bug which appears to have caused a RegionServer to crash while
running a topN aggregate query. This left a large number of files in {{/tmp}} after the RS
had gone away (due to a JVM SIGBUS crash). MappedByteBufferQueue will buffer results in memory
up to 20MB by default (controlled by {{phoenix.query.spoolThresholdBytes}}) and then start
appending them to a file. I'm seeing two things which could be improved:
>  * If the RS exits abnormally, there is no process to clean up files - would be nice
to register the {{deleteOnExit()}} hook to try to clean these up.
>  * There is no ability to control where MappedByteBufferQueue writes its spool file -
would be nice to use something other than /tmp (I think we have a property to control this
already in our config..)
> FYI []

This message was sent by Atlassian JIRA

View raw message