phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] gjacoby126 commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes for Non-Transactional Tables
Date Mon, 18 Mar 2019 21:40:53 GMT
gjacoby126 commented on a change in pull request #469: PHOENIX-5156 Consistent Global Indexes
for Non-Transactional Tables
URL: https://github.com/apache/phoenix/pull/469#discussion_r266652409
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/RegionScannerFactory.java
 ##########
 @@ -169,7 +177,13 @@ public long getMvccReadPoint() {
       @Override
       public boolean nextRaw(List<Cell> result) throws IOException {
         try {
-          boolean next = s.nextRaw(result);
+          boolean next;
+          do {
 
 Review comment:
   Also some comments explaining what verifyRow == false or true means -- I had to read the
verifyRow implementation a couple of times to figure it out. :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message