phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] comnetwork commented on a change in pull request #444: PHOENIX-5148
Date Thu, 14 Mar 2019 03:54:12 GMT
comnetwork commented on a change in pull request #444: PHOENIX-5148
URL: https://github.com/apache/phoenix/pull/444#discussion_r265411058
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/execute/AggregatePlan.java
 ##########
 @@ -327,4 +333,15 @@ public boolean useRoundRobinIterator() throws SQLException {
         return visitor.visit(this);
     }
 
+    private static OrderBy convertActualOutputOrderBy(OrderBy orderBy, GroupBy groupBy, StatementContext
statementContext) {
 
 Review comment:
   Not every plan have to  implement this function, eg. HashJoinPlan and SortMergeJoinPlan.
   In my opinion, this method is not suitable to declared as abstract method in QueryPlan
and subclass to override it , because this method is invoked in the ctor of concrete  subclass.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message