phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] vincentpoon commented on a change in pull request #462: PHOENIX-2787 support IF EXISTS for ALTER TABLE SET options
Date Tue, 12 Mar 2019 00:47:43 GMT
vincentpoon commented on a change in pull request #462: PHOENIX-2787 support IF EXISTS for
ALTER TABLE SET options
URL: https://github.com/apache/phoenix/pull/462#discussion_r264484667
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java
 ##########
 @@ -430,6 +430,10 @@ public Integer call() throws SQLException {
                                         return executeMutation(stmt, false);
                                     }
                                 }
+                                if (stmt instanceof ExecutableAddColumnStatement &&
+                                        ((ExecutableAddColumnStatement) stmt).ifSetOptionExists())
{
+                                    return 0;
 
 Review comment:
   Why do we need this in this catching of exception?  We shouldn't need this here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message