phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] vincentpoon commented on a change in pull request #460: PHOENIX-5184: HBase and Phoenix connection leaks in Indexing code path, OrphanViewTool and PhoenixConfigurationUtil
Date Sat, 09 Mar 2019 02:15:29 GMT
vincentpoon commented on a change in pull request #460: PHOENIX-5184: HBase and Phoenix connection
leaks in Indexing code path, OrphanViewTool and PhoenixConfigurationUtil
URL: https://github.com/apache/phoenix/pull/460#discussion_r263981310
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexScrutinyMapper.java
 ##########
 @@ -151,6 +151,16 @@ protected void setup(final Context context) throws IOException, InterruptedExcep
             LOG.info("Target table base query: " + targetTableQuery);
             md5 = MessageDigest.getInstance("MD5");
         } catch (SQLException | NoSuchAlgorithmException e) {
+            if (this.connection != null) {
+                try {
+                    this.connection.close();
 
 Review comment:
   in the rare case that this throws, `outputConn` will not get closed.  Looks like we need
to fix it in `cleanup()` also

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message