phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] karanmehta93 commented on a change in pull request #453: [PHOENIX-5172] Harden the PQS canary synth test tool with retry mechanism and more logging
Date Wed, 06 Mar 2019 20:07:16 GMT
karanmehta93 commented on a change in pull request #453: [PHOENIX-5172] Harden the PQS canary
synth test tool with retry mechanism and more logging
URL: https://github.com/apache/phoenix/pull/453#discussion_r263113339
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/tool/PhoenixCanaryTool.java
 ##########
 @@ -464,11 +364,60 @@ public Void call() {
         return 0;
     }
 
+    private static Connection getConnectionWithRetry(String connectionURL, Properties connProps){
+        Connection connection = null;
+        boolean isSuccess;
+        int currentAttempt = 1;
+        do {
+            try {
+                connection = DriverManager.getConnection(connectionURL, connProps);
+                LOG.info("Successfully established connection within "
+                        +currentAttempt+ "/" + MAX_ATTEMPTS + " attempts");
+                LOG.info("connectionURL :" +connectionURL);
+                LOG.info("connProps :" + connProps);
+                isSuccess = true;
+            } catch (Exception e) {
+                LOG.error("Failed to get connection." +
+                        " Exhausted attempts : "+ currentAttempt+ "/" + MAX_ATTEMPTS);
+                LOG.error("connectionURL :" + connectionURL);
+                LOG.error("connProps :" + connProps);
+                LOG.error("Something went wrong while getting Connection", e);
+                isSuccess = false;
+                sleepBeforeRetry(currentAttempt);
+                currentAttempt++;
+            }
+        } while (isSuccess != true && currentAttempt <= MAX_ATTEMPTS);
+        return connection;
+    }
+
+    private static void sleepBeforeRetry(int attempt) {
+        final int sleepTimesInSeconds= getSleepTime(attempt);
+        try {
+            LOG.info("Sleeping for " + sleepTimesInSeconds +" seconds");
+            TimeUnit.SECONDS.sleep(sleepTimesInSeconds);
+        } catch (InterruptedException e) {
+            LOG.error("Thread interrupted", e);
+        }
+    }
+
+    //fibonacci sequence of sleep interval
+    private static int getSleepTime(int attempt) {
 
 Review comment:
   for 5 retries you can probably hard code the array. The max we will do anytime will be
10, which still can be hardcoded. 
   See `HConstants#RETRY_BACKOFF`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message