phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] vincentpoon commented on a change in pull request #453: [PHOENIX-5172] Harden the PQS canary synth test tool with retry mechanism and more logging
Date Wed, 06 Mar 2019 19:04:39 GMT
vincentpoon commented on a change in pull request #453: [PHOENIX-5172] Harden the PQS canary
synth test tool with retry mechanism and more logging
URL: https://github.com/apache/phoenix/pull/453#discussion_r263086312
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/tool/PhoenixCanaryTool.java
 ##########
 @@ -50,14 +49,19 @@
 
 /**
  * A Canary Tool to perform synthetic tests for Query Server
+ * It assumes that TEST.PQSTEST or the schema.table passed in the argument
+ * is already present as following command
+ * CREATE TABLE IF NOT EXISTS TEST.PQSTEST (mykey INTEGER NOT NULL
+ * PRIMARY KEY, mycolumn VARCHAR, insert_date TIMESTAMP);
+ *
  */
 public class PhoenixCanaryTool extends Configured implements Tool {
 
     private static String TEST_SCHEMA_NAME = "TEST";
     private static String TEST_TABLE_NAME = "PQSTEST";
     private static String FQ_TABLE_NAME = "TEST.PQSTEST";
-    private boolean USE_NAMESPACE = true;
-
+    private static Timestamp timestamp;
+    private final static int MAX_ATTEMPTS = 5;
 
 Review comment:
   nit: phoenix convention is generally `static final` instead of `final static`
   
   Also, MAX_CONNECTION_ATTEMPTS perhaps makes the intent clearer.  Otherwise, it could be
interpreted as attempts at running a particular test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message