phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [phoenix] vincentpoon commented on a change in pull request #453: [PHOENIX-5172] Harden the PQS canary synth test tool with retry mechanism and more logging
Date Wed, 06 Mar 2019 19:04:39 GMT
vincentpoon commented on a change in pull request #453: [PHOENIX-5172] Harden the PQS canary
synth test tool with retry mechanism and more logging
URL: https://github.com/apache/phoenix/pull/453#discussion_r263079501
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/tool/PhoenixCanaryTool.java
 ##########
 @@ -174,7 +133,8 @@ void onExecute() throws Exception {
                 Integer myKey = rs.getInt(1);
                 String myColumn = rs.getString(2);
                 if (myKey != 1 || !myColumn.equals("Hello World")) {
-                    throw new Exception("Retrieved values do not match the inserted " + "values");
+                    throw new Exception("Retrieved values do not " +
 
 Review comment:
   nit: don't need "+" concatenation here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message