From issues-return-4745-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Feb 22 02:15:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6287E18064C for ; Fri, 22 Feb 2019 03:15:04 +0100 (CET) Received: (qmail 52099 invoked by uid 500); 22 Feb 2019 02:15:03 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 52084 invoked by uid 99); 22 Feb 2019 02:15:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Feb 2019 02:15:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id ACB9C18238E for ; Fri, 22 Feb 2019 02:15:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Uaw1IB1PCi2F for ; Fri, 22 Feb 2019 02:15:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 283BA5F430 for ; Fri, 22 Feb 2019 02:15:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9DF82E27C2 for ; Fri, 22 Feb 2019 02:15:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3ADAA2452D for ; Fri, 22 Feb 2019 02:15:00 +0000 (UTC) Date: Fri, 22 Feb 2019 02:15:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5137) Index Rebuilder scan increases data table region split time MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5137?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 774693#comment-16774693 ]=20 Hadoop QA commented on PHOENIX-5137: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest a= ttachment=20 http://issues.apache.org/jira/secure/attachment/12959696/PHOENIX-5137-4.1= 4-HBase-1.3.02.patch against master branch at commit f9908c80ed8d986325867b44adf119f2d26ff783. ATTACHMENT ID: 12959696 {color:green}+1 @author{color}. The patch does not contain any @author= tags. {color:red}-1 tests included{color}. The patch doesn't appear to inclu= de any new or modified tests. Please justify why no new tests are needed for this= patch. Also please list what manual steps were performed t= o verify this patch. {color:red}-1 patch{color}. The patch command could not apply the patc= h. Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2351/= /console This message is automatically generated. > Index Rebuilder scan increases data table region split time > ----------------------------------------------------------- > > Key: PHOENIX-5137 > URL: https://issues.apache.org/jira/browse/PHOENIX-5137 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.14.1 > Reporter: Kiran Kumar Maturi > Assignee: Kiran Kumar Maturi > Priority: Major > Attachments: PHOENIX-5137-4.14-HBase-1.3.02.patch, PHOENIX-5137-4= .14-Hbase-1.3.01.patch, PHOENIX-5137-4.14-Hbase-1.3.01.patch > > > [~lhofhansl] [~vincentpoon] [~tdsilva] please review > In order to differentiate between the index rebuilder retries=C2=A0=C2=A0= (UngroupedAggregateRegionObserver.rebuildIndices()) and=C2=A0commits that h= appen in the loop of UngroupedAggregateRegionObserver.doPostScannerOpen() a= s part of =C2=A0PHOENIX-4600=C2=A0blockingMemstoreSize was set to -1 for re= buildIndices; > {code:java} > commitBatchWithRetries(region, mutations, -1);{code} > blocks the region split as the check for region closing does not happen= =C2=A0 blockingMemstoreSize > 0 > {code:java} > for (int i =3D 0; blockingMemstoreSize > 0 && region.getMemstoreSize() > = blockingMemstoreSize && i < 30; i++) { > try{ > checkForRegionClosing(); > .... > {code} > Plan is to have the check for region closing at least once before committ= ing the batch > {code:java} > checkForRegionClosing(); > for (int i =3D 0; blockingMemstoreSize > 0 && region.getMemstoreSize() > = blockingMemstoreSize && i < 30; i++) { > try{ > checkForRegionClosing(); > .... > {code} > Steps to reproduce=20 > 1. Create a table with one index (startime)=20 > 2. Add 1-2 million rows=20 > 3. Wait till the index is active=20 > 4. Disable the index with start time (noted in step 1)=20 > 5. Once the rebuilder starts split data table region=20 > Repeat the steps again after applying the patch to check the difference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)