From issues-return-4739-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Feb 21 17:06:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DAE1D18064C for ; Thu, 21 Feb 2019 18:06:04 +0100 (CET) Received: (qmail 95488 invoked by uid 500); 21 Feb 2019 17:06:04 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 95479 invoked by uid 99); 21 Feb 2019 17:06:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Feb 2019 17:06:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 82CE9C282E for ; Thu, 21 Feb 2019 17:06:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id nR2ezYvhg64i for ; Thu, 21 Feb 2019 17:06:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C90805F644 for ; Thu, 21 Feb 2019 17:06:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 10C74E00A9 for ; Thu, 21 Feb 2019 17:06:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id BFB5B2452B for ; Thu, 21 Feb 2019 17:06:00 +0000 (UTC) Date: Thu, 21 Feb 2019 17:06:00 +0000 (UTC) From: "Kiran Kumar Maturi (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5137) Index Rebuilder scan increases data table region split time MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5137?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 774315#comment-16774315 ]=20 Kiran Kumar Maturi commented on PHOENIX-5137: --------------------------------------------- [~vincentpoon] [~mnpoonia] yes we should pass the blockingMemstoreSize ins= tead of -1.=20 Considering the following scenarios in case of index rebuilder 1. region is splitting and region.getMemstoreSize() < blockingMemstoreSize = then checkForRegionClosingOrSplitting() won't be called. 2. region is not splitting and region.getMemstoreSize() > blockingMemstoreS= ize rebuilder should wait. In order to have the above conditions satisfied and avoid contention issues= . we can call checkForRegionClosingOrSplitting() in rebuildIndices(...) be= fore commitBatchWithRetries(...) and as well pass the blockingMemstoreSize.= I have created a patch please review. > Index Rebuilder scan increases data table region split time > ----------------------------------------------------------- > > Key: PHOENIX-5137 > URL: https://issues.apache.org/jira/browse/PHOENIX-5137 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.14.1 > Reporter: Kiran Kumar Maturi > Assignee: Kiran Kumar Maturi > Priority: Major > Attachments: PHOENIX-5137-4.14-Hbase-1.3.01.patch, PHOENIX-5137-4= .14-Hbase-1.3.01.patch > > > [~lhofhansl] [~vincentpoon] [~tdsilva] please review > In order to differentiate between the index rebuilder retries=C2=A0=C2=A0= (UngroupedAggregateRegionObserver.rebuildIndices()) and=C2=A0commits that h= appen in the loop of UngroupedAggregateRegionObserver.doPostScannerOpen() a= s part of =C2=A0PHOENIX-4600=C2=A0blockingMemstoreSize was set to -1 for re= buildIndices; > {code:java} > commitBatchWithRetries(region, mutations, -1);{code} > blocks the region split as the check for region closing does not happen= =C2=A0 blockingMemstoreSize > 0 > {code:java} > for (int i =3D 0; blockingMemstoreSize > 0 && region.getMemstoreSize() > = blockingMemstoreSize && i < 30; i++) { > try{ > checkForRegionClosing(); > .... > {code} > Plan is to have the check for region closing at least once before committ= ing the batch > {code:java} > checkForRegionClosing(); > for (int i =3D 0; blockingMemstoreSize > 0 && region.getMemstoreSize() > = blockingMemstoreSize && i < 30; i++) { > try{ > checkForRegionClosing(); > .... > {code} > Steps to reproduce=20 > 1. Create a table with one index (startime)=20 > 2. Add 1-2 million rows=20 > 3. Wait till the index is active=20 > 4. Disable the index with start time (noted in step 1)=20 > 5. Once the rebuilder starts split data table region=20 > Repeat the steps again after applying the patch to check the difference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)