From issues-return-4831-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Feb 28 04:36:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9CB97180608 for ; Thu, 28 Feb 2019 05:36:05 +0100 (CET) Received: (qmail 65851 invoked by uid 500); 28 Feb 2019 04:36:04 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 65842 invoked by uid 99); 28 Feb 2019 04:36:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Feb 2019 04:36:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 12273C2824 for ; Thu, 28 Feb 2019 04:36:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id XNpAi__aT-Bn for ; Thu, 28 Feb 2019 04:36:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C51115FB9C for ; Thu, 28 Feb 2019 04:36:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CF1E1E2801 for ; Thu, 28 Feb 2019 04:36:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4DFF02457A for ; Thu, 28 Feb 2019 04:36:00 +0000 (UTC) Date: Thu, 28 Feb 2019 04:36:00 +0000 (UTC) From: "Swaroopa Kadam (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5130) removed 'static' keyword from 'private static enum'. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5130?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 780093#comment-16780093 ]=20 Swaroopa Kadam commented on PHOENIX-5130: ----------------------------------------- [~glqdlt] can you please also submit the patch, so that tests can be run it= ? > removed 'static' keyword from 'private static enum'. > ---------------------------------------------------- > > Key: PHOENIX-5130 > URL: https://issues.apache.org/jira/browse/PHOENIX-5130 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 5.1.0 > Reporter: Jeon, Il Woong > Priority: Trivial > Fix For: 5.1.0 > > Original Estimate: 1m > Time Spent: 10m > Remaining Estimate: 0h > > Hello :) > I did found 'private static enum'. > 'static' keyword is unnecessary for enum type. > 'Nested enum types are implicitly static(https://docs.oracle.com/javase/s= pecs/jls/se8/html/jls-8.html#jls-8.9)'. > So I removed 'static' keyword from 'private static enum'. > [https://github.com/apache/phoenix/pull/438] > Thank you for reading. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)