From issues-return-4395-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Sun Feb 3 19:05:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8D739180626 for ; Sun, 3 Feb 2019 20:05:03 +0100 (CET) Received: (qmail 70477 invoked by uid 500); 3 Feb 2019 19:05:02 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 70213 invoked by uid 99); 3 Feb 2019 19:05:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Feb 2019 19:05:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3D225C26E7 for ; Sun, 3 Feb 2019 19:05:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.801 X-Spam-Level: X-Spam-Status: No, score=-109.801 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id iHHJfiT66eDU for ; Sun, 3 Feb 2019 19:05:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 01EA65F4A3 for ; Sun, 3 Feb 2019 19:05:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8D459E2681 for ; Sun, 3 Feb 2019 19:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0EAE7243F2 for ; Sun, 3 Feb 2019 19:05:00 +0000 (UTC) Date: Sun, 3 Feb 2019 19:05:00 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Issue Comment Deleted] (PHOENIX-5119) Work around RpcScheduler interface differences in HBase 1.5 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated PHOENIX-5119: ------------------------------------ Comment: was deleted (was: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12957349/PHOENIX-5119-4.x.patch against master branch at commit 52b5d9d5f8d1f41218956bb6099a3d7eaf50939a. ATTACHMENT ID: 12957349 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2294//console This message is automatically generated.) > Work around RpcScheduler interface differences in HBase 1.5 > ----------------------------------------------------------- > > Key: PHOENIX-5119 > URL: https://issues.apache.org/jira/browse/PHOENIX-5119 > Project: Phoenix > Issue Type: Bug > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Priority: Major > Attachments: PHOENIX-5119-4.x.patch > > > The RpcScheduler interface in HBase 1.5 has three new methods for exposing per handler type counts for RPC metrics. Implement them using reflection and avoid use of any @Override annotations so the code will continue to compile against earlier versions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)