From issues-return-4845-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Feb 28 10:08:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 759FD180657 for ; Thu, 28 Feb 2019 11:08:05 +0100 (CET) Received: (qmail 3813 invoked by uid 500); 28 Feb 2019 10:08:04 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 3803 invoked by uid 99); 28 Feb 2019 10:08:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Feb 2019 10:08:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 09EF1C96EA for ; Thu, 28 Feb 2019 10:08:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id VLLjqrUTGKZb for ; Thu, 28 Feb 2019 10:08:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5EC975F341 for ; Thu, 28 Feb 2019 10:08:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7EB26E2801 for ; Thu, 28 Feb 2019 10:08:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1B43F24573 for ; Thu, 28 Feb 2019 10:08:00 +0000 (UTC) Date: Thu, 28 Feb 2019 10:08:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-2265) Disallow creation of view over HBase table if PK not specified MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780335#comment-16780335 ] Hadoop QA commented on PHOENIX-2265: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12960527/PHOENIX-2265-master.patch against master branch at commit 52e24fce2d8d335cb261891927e7b0704c0c5256. ATTACHMENT ID: 12960527 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 release audit{color}. The applied patch generated 1 release audit warnings (more than the master's current 0 warnings). {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ChangePermissionsIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableDDLPermissionsIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2364//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2364//artifact/patchprocess/patchReleaseAuditWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2364//console This message is automatically generated. > Disallow creation of view over HBase table if PK not specified > -------------------------------------------------------------- > > Key: PHOENIX-2265 > URL: https://issues.apache.org/jira/browse/PHOENIX-2265 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Assignee: Xinyi Yan > Priority: Major > Labels: newbie > Attachments: PHOENIX-2265-master.patch, PHOENIX-2265.patch, PHOENIX-2265.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > We currently allow a Phoenix view to be defined over an HBase table without specifying a primary key. > To repro, create an HBase table in the HBase shell: > {code} > create 'hb1', 'f1' > {code} > Then create a view in Phoenix: > {code} > create view "hb1"("f1".a varchar); > {code} > This should yield an error, as we haven't specified a primary key. -- This message was sent by Atlassian JIRA (v7.6.3#76005)