From issues-return-4825-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Wed Feb 27 22:44:13 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 53037180608 for ; Wed, 27 Feb 2019 23:44:13 +0100 (CET) Received: (qmail 81058 invoked by uid 500); 27 Feb 2019 22:44:12 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 81049 invoked by uid 99); 27 Feb 2019 22:44:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Feb 2019 22:44:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id CD07AC28AD for ; Wed, 27 Feb 2019 22:44:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 03RZVgV7MUDI for ; Wed, 27 Feb 2019 22:44:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2FB835FB73 for ; Wed, 27 Feb 2019 22:37:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6D1C9E2800 for ; Wed, 27 Feb 2019 22:37:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 425042457B for ; Wed, 27 Feb 2019 22:37:00 +0000 (UTC) Date: Wed, 27 Feb 2019 22:37:00 +0000 (UTC) From: "Geoffrey Jacoby (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-2265) Disallow creation of view over HBase table if PK not specified MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779840#comment-16779840 ] Geoffrey Jacoby commented on PHOENIX-2265: ------------------------------------------ [~yanxinyi] - Thanks for moving the test. You don't need to create a new minicluster in your new test, however, because ViewIT should already have one running, so you should just use that. (You should be able to check the other tests to see how to access a Phoenix connection and generate a unique table or view name that doesn't interfere with other tables that other tests might have created.) Also could you please try running TableDDLPermissionsIT locally to make sure it still passes with your changes present. Looks like the errors above came from timeouts. Once those two things are done I think this is just about ready to go in. > Disallow creation of view over HBase table if PK not specified > -------------------------------------------------------------- > > Key: PHOENIX-2265 > URL: https://issues.apache.org/jira/browse/PHOENIX-2265 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Assignee: Xinyi Yan > Priority: Major > Labels: newbie > Attachments: PHOENIX-2265-master-2.patch, PHOENIX-2265-master-3.patch, PHOENIX-2265-master.patch, PHOENIX-2265.patch, PHOENIX-2265.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > We currently allow a Phoenix view to be defined over an HBase table without specifying a primary key. > To repro, create an HBase table in the HBase shell: > {code} > create 'hb1', 'f1' > {code} > Then create a view in Phoenix: > {code} > create view "hb1"("f1".a varchar); > {code} > This should yield an error, as we haven't specified a primary key. -- This message was sent by Atlassian JIRA (v7.6.3#76005)