From issues-return-4727-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Feb 21 00:47:43 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CC6E318077A for ; Thu, 21 Feb 2019 01:47:42 +0100 (CET) Received: (qmail 29449 invoked by uid 500); 21 Feb 2019 00:47:41 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 29431 invoked by uid 99); 21 Feb 2019 00:47:41 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Feb 2019 00:47:41 +0000 From: GitBox To: issues@phoenix.apache.org Subject: [GitHub] hnguyen08 opened a new pull request #443: PHOENIX-5136 Message-ID: <155071006128.23929.5168220127604239531.gitbox@gitbox.apache.org> Date: Thu, 21 Feb 2019 00:47:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hnguyen08 opened a new pull request #443: PHOENIX-5136 URL: https://github.com/apache/phoenix/pull/443 `NULL` values for rows that are inserted using `UPSERT ON DUPLICATE KEY UPDATE` will be stored in HBase as empty byte arrays. `NULL` values represented by empty byte arrays are not handled well in the `AndOrOperator.evaluate()`. Any child expression of the `AndOrOperator` that evaluates to `NULL` represented by empty byte array will get marked in `partialEvalState`, thus having no effect when the `AndOrOperator` is re-evaluated against a different cell from the same row. This causes problems because the child expression *should* be re-evaluated since it can still affect the final result. The fix ensures that `partialEvalState` is not marked if the child expression evaluates to a NULL value represented by empty array. Let me know if this fix is acceptable or if there is a better approach to this problem! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services