phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5139) PhoenixDriver lockInterruptibly usage could unlock without locking
Date Thu, 14 Feb 2019 04:12:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767867#comment-16767867
] 

Hadoop QA commented on PHOENIX-5139:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12958652/PHOENIX-5139.4.x-HBase-1.4.v1.patch
  against 4.x-HBase-1.4 branch at commit 207263f7f0e45ebea02f2f12bec1f7293ad737c5.
  ATTACHMENT ID: 12958652

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                // Lazy initialize QueryServices so that we only attempt to create an
HBase Configuration
+                // object upon the first attempt to connect to any cluster. Otherwise, an
attempt will be
+                final ConnectionInfo normalizedConnInfo = connInfo.normalize(services.getProps(),
info);
+                        connectionQueryServicesCache.get(normalizedConnInfo, new Callable<ConnectionQueryServices>()
{
+                                    connectionQueryServices = new ConnectionlessQueryServicesImpl(services,
normalizedConnInfo, info);
+                                    connectionQueryServices = new ConnectionQueryServicesImpl(services,
normalizedConnInfo, info);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.trace.PhoenixTracingEndToEndIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2336//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2336//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2336//console

This message is automatically generated.

> PhoenixDriver lockInterruptibly usage could unlock without locking
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-5139
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5139
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.0, 5.1.0
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>            Priority: Major
>         Attachments: PHOENIX-5139.4.x-HBase-1.4.v1.patch
>
>
> We have calls to lockInterruptibly surrounded by a finally call to unlock, but there's
a chance InterruptedException was thrown and we didn't obtain the lock.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message