phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5137) Index Rebuilder scan increases data table region split time
Date Fri, 15 Feb 2019 16:44:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769492#comment-16769492
] 

Hadoop QA commented on PHOENIX-5137:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12958888/PHOENIX-5137-4.14-Hbase-1.3.01.patch
  against master branch at commit 5f56a4b993435f6b127d0c561d4a6c458f263e46.
  ATTACHMENT ID: 12958888

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.PartialIndexRebuilderIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2339//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2339//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2339//console

This message is automatically generated.

> Index Rebuilder scan increases data table region split time
> -----------------------------------------------------------
>
>                 Key: PHOENIX-5137
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5137
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.1
>            Reporter: Kiran Kumar Maturi
>            Assignee: Kiran Kumar Maturi
>            Priority: Major
>         Attachments: PHOENIX-5137-4.14-Hbase-1.3.01.patch, PHOENIX-5137-4.14-Hbase-1.3.01.patch
>
>
> [~lhofhansl] [~vincentpoon] [~tdsilva] please review
> In order to differentiate between the index rebuilder retries  (UngroupedAggregateRegionObserver.rebuildIndices())
and commits that happen in the loop of UngroupedAggregateRegionObserver.doPostScannerOpen()
as part of  PHOENIX-4600 blockingMemstoreSize was set to -1 for rebuildIndices;
> {code:java}
> commitBatchWithRetries(region, mutations, -1);{code}
> blocks the region split as the check for region closing does not happen  blockingMemstoreSize
> 0
> {code:java}
> for (int i = 0; blockingMemstoreSize > 0 && region.getMemstoreSize() >
blockingMemstoreSize && i < 30; i++) {
>   try{
>    checkForRegionClosing();
>    ....
> {code}
> Plan is to have the check for region closing at least once before committing the batch
> {code:java}
> int i = 0;
> do {
>    try {
>      if (i > 0) {
>          Thread.sleep(100); 
>      }
>      checkForRegionClosing();   
>     } catch (InterruptedException e) {
>         Thread.currentThread().interrupt();
>         throw new IOException(e);
>     }
> }while (blockingMemstoreSize > 0 && region.getMemstoreSize() > blockingMemstoreSize
&& i++ < 30);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message