phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5120) Avoid using MappedByteBuffers for server side sorting.
Date Mon, 04 Feb 2019 19:23:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760131#comment-16760131
] 

Andrew Purtell commented on PHOENIX-5120:
-----------------------------------------

+1

New test OrderByWithSpillingIT needs an ASF copyright header.

MappedByteBufferQueue should be renamed now that it's not using MappedByteBuffers. Just rename
the compilation unit to BufferQueue? Same comment applies to MappedByteBufferSortedQueue.

If at some future time we still need random access (via RandomAccessFile) we could just use
it directly I think. No need to map it.

> Avoid using MappedByteBuffers for server side sorting.
> ------------------------------------------------------
>
>                 Key: PHOENIX-5120
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5120
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Critical
>         Attachments: 5120-1.4-v2.txt, 5120-1.4-v3.txt, 5120-1.4-wip.txt, 5120-1.4.txt,
5120-master.txt
>
>
> We should had a production outage due to this.
> MappedByteBuffer may leave files around, on top they use direct memory, which is not
cleared until the JVM executes a full GC.
> See last comment on PHOENIX-2405.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message