phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-5111) IndexTool gives NPE when trying to do a direct build without an output-path set
Date Tue, 05 Feb 2019 02:13:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-5111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760394#comment-16760394
] 

Hadoop QA commented on PHOENIX-5111:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12957548/PHOENIX-5111.patch
  against master branch at commit 52b5d9d5f8d1f41218956bb6099a3d7eaf50939a.
  ATTACHMENT ID: 12957548

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                return configureJobForAsyncIndex(schemaName, indexTable, dataTable, useDirectApi,
useSnapshot);
+        private Job configureJobForAsyncIndex(String schemaName, String indexTable, String
dataTable, boolean useDirectApi, boolean useSnapshot)

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.schema.stats.NoOpStatsCollectorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SpillableGroupByIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2300//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2300//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2300//console

This message is automatically generated.

> IndexTool gives NPE when trying to do a direct build without an output-path set
> -------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5111
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5111
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.1
>            Reporter: Geoffrey Jacoby
>            Assignee: Gokcen Iskender
>            Priority: Minor
>         Attachments: PHOENIX-5111.patch, PHOENIX-5111.patch
>
>
> The IndexTool has several modes. If the -direct or -partial-rebuild flags are not set,
the tool assumes the user wants to rebuild the index by creating HFiles and then bulk-loading
them back into HBase, and requires an extra -output-path flag to deterine where the temporary
HFiles should live. 
> In practice, we've found that -direct mode (which loads using HBase Puts) is quicker.
However, even though there's logic to not require the -output-path flag when -direct mode
is chosen, the IndexTool will throw an NPE if it's not present. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message