phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4918) Apache Phoenix website Grammar page is running on an old version
Date Tue, 26 Feb 2019 06:43:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777645#comment-16777645
] 

Hadoop QA commented on PHOENIX-4918:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12960121/PHOENIX-4918.patch
  against master branch at commit 122ea979da2539308efaa78a92c4939b94e415bb.
  ATTACHMENT ID: 12960121

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +[ OFFSET {bindParameter | number} [ ROW | ROWS ] ] [ FETCH { FIRST | NEXT } {bindParameter
| number} { ROW | ROWS } ONLY ]
+LIMIT(or FETCH FIRST) limits the number of rows returned by the query with no limit applied
if unspecified or specified
+as null or less than zero. The LIMIT(or FETCH FIRST) clause is executed after the ORDER BY
clause to support top-N type
+Use the ON DUPLICATE KEY clause (available in Phoenix 4.9) if you need the UPSERT to be atomic.
Performance
+if they don't already exist. All table, column family and column names are uppercased unless
they are double quoted in which case they are case sensitive.
+At create time, to improve query performance, an empty key value is added to the first column
family of any existing rows or the default column family if no column families are explicitly
defined. Upserts will also add this empty key value. This improves query performance by having
a key value column we can guarantee always being there and thus minimizing the amount of data
that must be projected and subsequently returned back to the client. HBase table and column
configuration options may be passed through as key/value pairs to configure the HBase table
as desired. Note that when using the IF NOT EXISTS clause, if a table already exists, then
no change will be made to it. Additionally, no validation is done to check whether the existing
table metadata matches the proposed table metadata. so it's better to use DROP TABLE followed
by CREATE TABLE is the table metadata may be changing.
+Drops a table. The optional CASCADE keyword causes any views on the table to be dropped as
well. When dropping a table, by default the underlying HBase data and index tables are dropped.
The phoenix.schema.dropMetaData
+Creates a new function. The function name is uppercased unless they are double quoted in
which case they are case sensitive. The function accepts zero or more arguments. The class
name and jar path should be in single quotes. The jar path is optional and if not specified
then the class name will be loaded from the jars present in directory configured for hbase.dynamic.jars.dir.
+CREATE FUNCTION my_reverse(varchar) returns varchar as 'com.mypackage.MyReverseFunction'
using jar 'hdfs:/localhost:8080/hbase/lib/myjar.jar'
+CREATE FUNCTION my_increment(integer, integer constant defaultvalue='10') returns integer
as 'com.mypackage.MyIncrementFunction' using jar '/hbase/lib/myincrement.jar'

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ChangePermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableDDLPermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2355//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2355//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2355//console

This message is automatically generated.

> Apache Phoenix website Grammar page is running on an old version
> ----------------------------------------------------------------
>
>                 Key: PHOENIX-4918
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4918
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Xu Cang
>            Assignee: Xinyi Yan
>            Priority: Trivial
>         Attachments: PHOENIX-4918.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> For example this query example is incorrect: CREATE TABLE my_schema.my_table ( id BIGINT
not null primary key, date)
>  
> [https://phoenix.apache.org/language/index.html]
> I checked the master branch and 4.x branch, the code is correct though. Meaning the
website is using a very old version of phoenix.csv.
> Any plan to update it? thanks.
>  FYI [~karanmehta93]  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message