phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geoffrey Jacoby (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4345) Error message for incorrect index is not accurate
Date Thu, 28 Feb 2019 18:44:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780823#comment-16780823
] 

Geoffrey Jacoby commented on PHOENIX-4345:
------------------------------------------

Thanks for the patch, [~yanxinyi]. A few thoughts:

1. When creating a new file to add to Phoenix, it's important to include the Apache license
at the top.

2. Your patch adds a new method to FromCompiler which takes a parameter called isIndexTable
that is always passed in "true" and is never used in the body of the method. It would probably
be cleaner and clearer to either have a new method name (such as "getIndexResolver"), or have
a unified method that uses isIndexTable to give the appropriate error (probably with the old
getResolver method becoming a pass-through with isIndexTable = false.

3. Are you sure this is the only place that needs to call your new method? 



> Error message for incorrect index is not accurate
> -------------------------------------------------
>
>                 Key: PHOENIX-4345
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4345
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ethan Wang
>            Assignee: Xinyi Yan
>            Priority: Trivial
>         Attachments: PHOENIX-4345.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Error message for incorrect index is not accurate. it shows "table undefined". rather,
should be index undefined.
> Table name: PERSON
> Index name: LOCAL_ADDRESS
> 0: jdbc:phoenix:localhost:2181:/hbase> ALTER INDEX LOCAL_ADDRESSX ON PERSON rebuild;
> Error: ERROR 1012 (42M03): Table undefined. tableName=LOCAL_ADDRESSX (state=42M03,code=1012)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message