phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3710) Cannot use lowername data table name with indextool
Date Fri, 22 Feb 2019 04:28:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774754#comment-16774754
] 

Hadoop QA commented on PHOENIX-3710:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12959687/PHOENIX-3710.002.rebased.patch
  against master branch at commit f9908c80ed8d986325867b44adf119f2d26ff783.
  ATTACHMENT ID: 12959687

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +                        "CREATE %s INDEX %s ON %s  (LPAD(UPPER(NAME, 'en_US'),8,'x')||'_xyz')
ASYNC ",
+                        "SELECT ID FROM %s WHERE LPAD(UPPER(NAME, 'en_US'),8,'x')||'_xyz'
= 'xxUNAME2_xyz'",
+                        + "    SERVER FILTER BY (LPAD(UPPER(NAME, 'en_US'), 8, 'x') || '_xyz')
= 'xxUNAME2_xyz'",
+            // Because the explain plan doesn't include double-quotes around case-sensitive
table names,
+            assertExplainPlan(localIndex, actualExplainPlan, dataTableNameForExplain, indexTableNameForExplain,
false);
+        assertExplainPlan(localIndex, actualExplainPlan, dataTableFullName, indexTableFullName,
true);
+                normalizeTableNames ? SchemaUtil.normalizeIdentifier(dataTableFullName) :
dataTableFullName);
+                normalizeTableNames ? SchemaUtil.normalizeIdentifier(indexTableFullName)
: indexTableFullName);
+            	PTable dataTable = PhoenixRuntime.getTable(conn, SchemaUtil.getTableName(schemaName,
dataTableName));
+                PhoenixMapReduceUtil.setInput(job, PhoenixIndexDBWritable.class, quotedDataTable,
selectQuery);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableDDLPermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ChangePermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2350//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2350//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2350//console

This message is automatically generated.

> Cannot use lowername data table name with indextool
> ---------------------------------------------------
>
>                 Key: PHOENIX-3710
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3710
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.8.0
>            Reporter: Matthew Shipton
>            Assignee: Josh Elser
>            Priority: Minor
>         Attachments: PHOENIX-3710.002.patch, PHOENIX-3710.002.rebased.patch, PHOENIX-3710.patch,
test.sh, test.sql
>
>
> {code}
> hbase org.apache.phoenix.mapreduce.index.IndexTool --data-table \"my_lowcase_table\"
--index-table INDEX_TABLE --output-path /tmp/some_path
> {code}
> results in:
> {code}
> java.lang.IllegalArgumentException:  INDEX_TABLE is not an index table for MY_LOWCASE_TABLE
> {code}
> This is despite the data table being explictly lowercased.
> Appears to be referring to the lowcase table, not the uppercase version.
> Workaround exists by changing the tablename, but this is not always feasible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message