phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geoffrey Jacoby (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-2265) Disallow creation of view over HBase table if PK not specified
Date Wed, 27 Feb 2019 22:37:00 GMT


Geoffrey Jacoby commented on PHOENIX-2265:

[~yanxinyi] - Thanks for moving the test. You don't need to create a new minicluster in your
new test, however, because ViewIT should already have one running, so you should just use
that. (You should be able to check the other tests to see how to access a Phoenix connection
and generate a unique table or view name that doesn't interfere with other tables that other
tests might have created.)

Also could you please try running TableDDLPermissionsIT locally to make sure it still passes
with your changes present. Looks like the errors above came from timeouts. 

Once those two things are done I think this is just about ready to go in. 

> Disallow creation of view over HBase table if PK not specified
> --------------------------------------------------------------
>                 Key: PHOENIX-2265
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Xinyi Yan
>            Priority: Major
>              Labels: newbie
>         Attachments: PHOENIX-2265-master-2.patch, PHOENIX-2265-master-3.patch, PHOENIX-2265-master.patch,
PHOENIX-2265.patch, PHOENIX-2265.patch
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
> We currently allow a Phoenix view to be defined over an HBase table without specifying
a primary key.
> To repro, create an HBase table in the HBase shell:
> {code}
>  create 'hb1', 'f1'
> {code}
> Then create a view in Phoenix:
> {code}
> create view "hb1"("f1".a varchar);
> {code}
> This should yield an error, as we haven't specified a primary key.

This message was sent by Atlassian JIRA

View raw message