phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] dbwong commented on a change in pull request #442: PHOENIX-5122: PHOENIX-4322 breaks client backward compatibility
Date Wed, 20 Feb 2019 21:37:24 GMT
dbwong commented on a change in pull request #442: PHOENIX-5122: PHOENIX-4322 breaks client
backward compatibility
URL: https://github.com/apache/phoenix/pull/442#discussion_r258683896
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/expression/RowValueConstructorExpression.java
 ##########
 @@ -46,14 +47,30 @@
     private ImmutableBytesWritable literalExprPtr;
     private int partialEvalIndex = -1;
     private int estimatedByteSize;
+    
+    // The boolean field that indicated the object is a literal constant, 
+    // has been repurposed to a bitset and now holds additional information. 
+    // This is to facilitate b/w compat to 4.13 clients.
+    // @see <a href="https://issues.apache.org/jira/browse/PHOENIX-5122">PHOENIX-5122</a>

+    private BitSet extraFields;
+    
+    private enum ExtraFieldPosition {
 
 Review comment:
   I dislike the ordinal Enum approach as it makes this enum order dependant and for example
adding a field to the beginning here could cause backwards compatibility problems as well.
 I'd prefer a enum constant with values.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message