phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kadirozde commented on a change in pull request #441: PHOENIX-5089 Add tenantId parameter to IndexScrunityTool
Date Wed, 20 Feb 2019 18:02:59 GMT
kadirozde commented on a change in pull request #441: PHOENIX-5089 Add tenantId parameter to
IndexScrunityTool
URL: https://github.com/apache/phoenix/pull/441#discussion_r258607538
 
 

 ##########
 File path: phoenix-core/src/test/java/org/apache/phoenix/mapreduce/index/IndexScrutinyTableOutputTest.java
 ##########
 @@ -43,7 +43,7 @@ public void testConstructMetadataParamQuery() {
     @Test
     public void testGetSqlQueryAllInvalidRows() throws SQLException {
         SourceTargetColumnNames columnNames =
-                new SourceTargetColumnNames.DataSourceColNames(pDataTable, pIndexTable);
+                new SourceTargetColumnNames.DataSourceColNames(pDataTable, pIndexTable, false);
 
 Review comment:
   Having a new constructor that takes the extra boolean parameter would eliminate changing
the existing code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message