phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kadirozde commented on a change in pull request #434: PHOENIX-5018 Index mutations created by UPSERT SELECT will have wrong…
Date Tue, 19 Feb 2019 18:39:56 GMT
kadirozde commented on a change in pull request #434: PHOENIX-5018 Index mutations created
by UPSERT SELECT will have wrong…
URL: https://github.com/apache/phoenix/pull/434#discussion_r258175004
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
 ##########
 @@ -1741,6 +1743,13 @@ public MutationState createIndex(CreateIndexStatement statement, byte[][]
splits
         if (connection.getSCN() != null) {
             return buildIndexAtTimeStamp(table, statement.getTable());
         }
+
+        String dataTableFullName = SchemaUtil.getTableName(
+                tableRef.getTable().getSchemaName().getString(),
+                tableRef.getTable().getTableName().getString());
 
 Review comment:
   @gjacoby126, I have removed the refresh code. Thank you for discovering this issue, helping
me understand the code, and reviewing the patch!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message