phoenix-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ChinmaySKulkarni commented on a change in pull request #428: PHOENIX-374: Enable access to dynamic columns in * or cf.* selection
Date Mon, 04 Feb 2019 23:50:48 GMT
ChinmaySKulkarni commented on a change in pull request #428: PHOENIX-374: Enable access to
dynamic columns in * or cf.* selection
URL: https://github.com/apache/phoenix/pull/428#discussion_r253692814
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
 ##########
 @@ -1124,9 +1129,11 @@ public PColumn getColumnForColumnQualifier(byte[] cf, byte[] cq) throws
ColumnNo
         private final long ts;
         private final boolean hasOnDupKey;
         // map from column name to value 
-        private Map<PColumn, byte[]> columnToValueMap; 
+        private Map<PColumn, byte[]> columnToValueMap;
+        // map from the column family name to the list of dynamic columns in that column
family
+        private Map<String, List<PColumn>> colFamToDynamicColumnsMapping;
 
-        public PRowImpl(KeyValueBuilder kvBuilder, ImmutableBytesWritable key, long ts, Integer
bucketNum, boolean hasOnDupKey) {
+        PRowImpl(KeyValueBuilder kvBuilder, ImmutableBytesWritable key, long ts, Integer
bucketNum, boolean hasOnDupKey) {
 
 Review comment:
   @gokceni This method does not require public scope hence I changed it to package-private

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message