From issues-return-4259-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Mon Jan 28 19:58:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D03D418060E for ; Mon, 28 Jan 2019 19:58:05 +0100 (CET) Received: (qmail 75470 invoked by uid 500); 28 Jan 2019 18:58:05 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 75461 invoked by uid 99); 28 Jan 2019 18:58:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jan 2019 18:58:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7F240C5630 for ; Mon, 28 Jan 2019 18:58:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id sui3fBUTL6Di for ; Mon, 28 Jan 2019 18:58:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F3C6A610B6 for ; Mon, 28 Jan 2019 18:58:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E1CA9E26A3 for ; Mon, 28 Jan 2019 18:58:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 47B62243A5 for ; Mon, 28 Jan 2019 18:58:00 +0000 (UTC) Date: Mon, 28 Jan 2019 18:58:00 +0000 (UTC) From: "Vincent Poon (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5080) Index becomes Active during Partial Index Rebuilder if Index Failure happens MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5080?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 754254#comment-16754254 ]=20 Vincent Poon commented on PHOENIX-5080: --------------------------------------- [~mihir6692] I think it would be more ideal if we could use EnvironmentEdg= eManager.injectEdge() to insert our own clock, so we have more control and = so the test doesn't wait any more than necessary. See ConcurrentMutationsI= T for examples. Also, instead of having a rebuildOnce static variable, it would be cleaner = to have runIndexRebuilderAsync return a Future that you check for completio= n. However I will say that your test does seem to follow the existing pattern = in that class. If you think it's overly burdensome to convert your test, w= e can commit this first and create another work item to clean up this test = class. > Index becomes Active during Partial Index Rebuilder if Index Failure happ= ens > -------------------------------------------------------------------------= --- > > Key: PHOENIX-5080 > URL: https://issues.apache.org/jira/browse/PHOENIX-5080 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.14.1 > Reporter: Monani Mihir > Assignee: Monani Mihir > Priority: Blocker > Attachments: PHOENIX-5080-4.x-HBase-1.3.01.patch, PHOENIX-5080-4.= x-HBase-1.3.02.patch, PHOENIX-5080-4.x-HBase-1.3.02.patch, PHOENIX-5080-4.x= -HBase-1.3.03.patch, PHOENIX-5080-4.x-HBase-1.3.04.patch > > > After PHOENIX-4130=C2=A0and PHOENIX-4600=C2=A0, If there is Index failure= during Partial Index Rebuild, Rebuilder will try again to write Index upda= tes. If it succeeds then it will transition Index from INACTIVE to ACTIVE, = even before Rebuilder finishes. > Here is where it goes wrong, I think :-=C2=A0 > {code:java} > PhoenixIndexFailurePolicy.java :-=20 > public static void doBatchWithRetries(MutateCommand mutateCommand, > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 IndexWriteException iwe, Phoeni= xConnection connection, ReadOnlyProps config) throws IOException { > .... > while (canRetryMore(numRetry++, maxTries, canRetryUntil)) { > ... > handleIndexWriteSuccessFromClient(iwe, connection); > ... > } > } > .... > private static void handleIndexWriteSuccessFromClient(IndexWriteException= indexWriteException, PhoenixConnection conn) { > =C2=A0 =C2=A0 =C2=A0 =C2=A0 handleExceptionFromClient(indexWriteException= , conn, PIndexState.ACTIVE); > } > {code} > =C2=A0 > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)