From issues-return-3738-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Jan 3 13:57:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 733F418067A for ; Thu, 3 Jan 2019 13:57:04 +0100 (CET) Received: (qmail 93622 invoked by uid 500); 3 Jan 2019 12:57:03 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 93613 invoked by uid 99); 3 Jan 2019 12:57:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jan 2019 12:57:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id ED0A4C22FB for ; Thu, 3 Jan 2019 12:57:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id GmqiFTHGaPWu for ; Thu, 3 Jan 2019 12:57:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 240A261103 for ; Thu, 3 Jan 2019 12:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 66812E262F for ; Thu, 3 Jan 2019 12:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1D55C253D4 for ; Thu, 3 Jan 2019 12:57:00 +0000 (UTC) Date: Thu, 3 Jan 2019 12:57:00 +0000 (UTC) From: "Monani Mihir (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5079) PhoenixIndexMetaData.isIndexRebuild gives wrong results in Partial Index Rebuilding MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5079?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 733001#comment-16733001 ]=20 Monani Mihir commented on PHOENIX-5079: --------------------------------------- Thanks [~vincentpoon] That clears my doubts . Will put up patch soon.=C2=A0 > PhoenixIndexMetaData.isIndexRebuild gives wrong results in Partial Index = Rebuilding > -------------------------------------------------------------------------= ---------- > > Key: PHOENIX-5079 > URL: https://issues.apache.org/jira/browse/PHOENIX-5079 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.14.1 > Reporter: Monani Mihir > Priority: Minor > > During Partial Rebuild, If rebuilder get index failure (because of region= move/split etc), it will call PhoenixIndexFailurePolicy.handleFailure . He= re it checks if mutations are part of Index Rebuild or not .=C2=A0 > {code:java} > if (!throwing) { > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SQLException sqlE= xception =3D > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 new SQLExceptionInfo.Builder(SQLExceptionCode.INDEX_WRITE_FAILUR= E) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .setRootCause(cause).setMessage(caus= e.getLocalizedMessage()).build() > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 .buildException(); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 IOException ioExc= eption =3D ServerUtil.wrapInDoNotRetryIOException(null, sqlException, times= tamp); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Mutation m =3D attempted.entrie= s().iterator().next().getValue(); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 boolean isIndexRebuild =3D Phoe= nixIndexMetaData.isIndexRebuild(m.getAttributesMap()); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 // Always throw if rebuilding i= ndex since the rebuilder needs to know if it was successful > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (throwIndexWriteFailure || i= sIndexRebuild) { > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 throw ioException; > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else { > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 LOG= .warn("Swallowing index write failure", ioException); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } > {code} > Here isIndexRebuild becomes=C2=A0false=C2=A0even though we have set attri= bute for REPLY_WRITE to=C2=A0 > REPLAY_ONLY_INDEX_WRITES=C2=A0 in UngroupedAggregateRegionObserver.rebuil= dIndices=C2=A0 > {code:java} > ... > put.setAttribute(REPLAY_WRITES, REPLAY_ONLY_INDEX_WRITES); > ...{code} > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)