From issues-return-4108-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Fri Jan 18 23:27:07 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 303B6180647 for ; Fri, 18 Jan 2019 23:27:07 +0100 (CET) Received: (qmail 2478 invoked by uid 500); 18 Jan 2019 22:27:06 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 2469 invoked by uid 99); 18 Jan 2019 22:27:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Jan 2019 22:27:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E181A1808C8 for ; Fri, 18 Jan 2019 22:27:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ksc9yemH2Ka6 for ; Fri, 18 Jan 2019 22:27:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 126E560F30 for ; Fri, 18 Jan 2019 22:27:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 15B17E269C for ; Fri, 18 Jan 2019 22:27:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 743062566C for ; Fri, 18 Jan 2019 22:27:00 +0000 (UTC) Date: Fri, 18 Jan 2019 22:27:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5069) Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5069?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 746734#comment-16746734 ]=20 Hadoop QA commented on PHOENIX-5069: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest a= ttachment=20 http://issues.apache.org/jira/secure/attachment/12955453/PHOENIX-5069.mas= ter.002.patch against master branch at commit c8686ce73093b879bbda5f08f3e7933a9708e110. ATTACHMENT ID: 12955453 {color:green}+1 @author{color}. The patch does not contain any @author= tags. {color:green}+1 tests included{color}. The patch appears to include 3 = new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the = total number of javac compiler warnings. {color:red}-1 release audit{color}. The applied patch generated 1 rele= ase audit warnings (more than the master's current 0 warnings). {color:red}-1 lineLengths{color}. The patch introduces the following l= ines longer than 100: + // 1. Load stats from the stats table only when the stats = get updated on the server side. + public GuidePostsInfo loadStats(GuidePostsKey statsKey, GuidePosts= Info prevGuidepostInfo) throws Exception { + new Object[] {Objects.hashCode(GuidePostsCache.thi= s), key, info.getEstimatedSize()}); + public GuidePostsInfo loadStats(GuidePostsKey statsKey, GuidePosts= Info prevGuidepostInfo) throws Exception { + logger.warn("Unable to load stats from tab= le: " + key.toString(), e); + * @param prevGuidepostInfo the existing stats cached on the client si= de or GuidePostsInfo.NO_GUIDEPOST + GuidePostsInfo loadStats(GuidePostsKey statsKey, GuidePostsInfo prevGu= idepostInfo) throws Exception; + // Those Java equivalents of sizeof() in C/C++, mentioned on the W= eb, might be overkilled here. + + SizedUtil.ARRAY_SIZE + this.gpTimestamps.length * SizedU= til.LONG_SIZE // gpTimestamps + public TestStatsLoaderImpl(CountDownLatch firstTimeRefreshedSignal= , CountDownLatch secondTimeRefreshedSignal) { {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end= .index.MutableIndexSplitReverseScanIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.inde= x.MutableIndexSplitForwardScanIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2255//t= estReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Bui= ld/2255//artifact/patchprocess/patchReleaseAuditWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2255/= /console This message is automatically generated. > Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cac= he > -------------------------------------------------------------------------= -- > > Key: PHOENIX-5069 > URL: https://issues.apache.org/jira/browse/PHOENIX-5069 > Project: Phoenix > Issue Type: Improvement > Reporter: Bin Shi > Assignee: Bin Shi > Priority: Major > Attachments: PHOENIX-5069.master.001.patch, PHOENIX-5069.master.0= 02.patch, PHOENIX-5069.patch > > Time Spent: 6h 20m > Remaining Estimate: 0h > > The current Phoenix Stats Cache uses TTL based eviction policy. A cached = entry will expire after a given amount of time (900s by default) passed sin= ce the entry's been created. This will lead to cache miss when Compiler/Opt= imizer fetches stats from cache at the next time. As you can see from the a= bove graph, fetching stats from the cache is a blocking operation =E2=80=94= when there is cache miss, it has a round trip over the wire to scan the SY= STEM.STATS Table and to get the latest stats info, rebuild the cache and fi= nally return the stats to the Compiler/Optimizer. Whenever there is a cache= miss, this blocking call causes significant performance penalty=C2=A0and s= ee periodic spikes. > *This Jira suggests to use=C2=A0asynchronous refresh mechanism=C2=A0to pr= ovide a non-blocking cache. For details, please see the linked design docum= ent below.* > [~karanmehta93] [~twdsilva@gmail.com]=C2=A0[~dbwong]=C2=A0[~elserj]=C2=A0= [~ankit@apache.org]=C2=A0[~sergey soldatov]=C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)