From issues-return-3842-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Tue Jan 8 03:20:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A3257180647 for ; Tue, 8 Jan 2019 03:20:05 +0100 (CET) Received: (qmail 76630 invoked by uid 500); 8 Jan 2019 02:20:04 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 76618 invoked by uid 99); 8 Jan 2019 02:20:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jan 2019 02:20:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 17416C24A5 for ; Tue, 8 Jan 2019 02:20:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id AjHg_WJKRLuG for ; Tue, 8 Jan 2019 02:20:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id F1CAC60E10 for ; Tue, 8 Jan 2019 02:20:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 566FAE02E3 for ; Tue, 8 Jan 2019 02:20:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B694A25560 for ; Tue, 8 Jan 2019 02:20:00 +0000 (UTC) Date: Tue, 8 Jan 2019 02:20:00 +0000 (UTC) From: "Kadir OZDEMIR (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-5018) Index mutations created by IndexTool will have wrong timestamps MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-5018?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 736641#comment-16736641 ]=20 Kadir OZDEMIR commented on PHOENIX-5018: ---------------------------------------- While discussing this further with [~vincentpoon], [~gjacoby] and [~tdsilva= ] in person, a third solution has emerged.=C2=A0 The third solution alternative is to change IndexTool to use the same code = path that MetaDataRegionObserver uses for partial index builds. This code p= ath leverages the doPostScannerOpen method of UngroupedRegionObserver rebui= ld index. This method scans the data table to get mutations, and replays th= ese mutations back on the data table with the REPLAY_ONLY_INDEX_WRITES attr= ibute on the mutations. Indexer (the coprocessor for managing index updates= ) checks this attribute and updates only the index tables for these mutatio= ns. =C2=A0By doing so the index tables get the right timestamps. Thus, Inde= xTool can be changed to leverage UngrouppedRegionObserver the same way Meta= DataRegionObserver does. This alternative achieves the code unification wit= hout loosing the benefits of MapReduce framework. > Index mutations created by IndexTool will have wrong timestamps > --------------------------------------------------------------- > > Key: PHOENIX-5018 > URL: https://issues.apache.org/jira/browse/PHOENIX-5018 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.14.0, 5.0.0 > Reporter: Geoffrey Jacoby > Assignee: Kadir OZDEMIR > Priority: Major > > When doing a full rebuild (or initial async build) on an index using the = IndexTool and PhoenixIndexImportDirectMapper, we generate the index mutatio= ns by creating an UPSERT SELECT query from the base table to the index, the= n taking the Mutations from it and inserting it directly into the index via= an HBase HTable.=20 > The timestamps of the Mutations use the default HBase behavior, which is = to take the current wall clock. However, the timestamp of an index KeyValue= should use the timestamp of the initial KeyValue in the base table. > Having base table and index timestamps out of sync can cause all sorts of= weird side effects, such as if the base table has data with an expired TTL= that isn't expired in the index yet.=20 -- This message was sent by Atlassian JIRA (v7.6.3#76005)