From issues-return-4324-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Jan 31 00:04:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B5358180652 for ; Thu, 31 Jan 2019 01:04:04 +0100 (CET) Received: (qmail 47187 invoked by uid 500); 31 Jan 2019 00:04:03 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 47177 invoked by uid 99); 31 Jan 2019 00:04:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Jan 2019 00:04:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 61DC8C03A6 for ; Thu, 31 Jan 2019 00:04:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 2vYvshACnL5F for ; Thu, 31 Jan 2019 00:04:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B18F75F1F0 for ; Thu, 31 Jan 2019 00:04:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1E789E26A5 for ; Thu, 31 Jan 2019 00:04:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 800AE243C3 for ; Thu, 31 Jan 2019 00:04:00 +0000 (UTC) Date: Thu, 31 Jan 2019 00:04:00 +0000 (UTC) From: "Hudson (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4993) Data table region should not close RS level shared/cached connections like IndexWriter, RecoveryIndexWriter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4993?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 756706#comment-16756706 ]=20 Hudson commented on PHOENIX-4993: --------------------------------- FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #2286 (See [ht= tps://builds.apache.org/job/PreCommit-PHOENIX-Build/2286/]) PHOENIX-4993 added test to check cached connections are not closed when (vi= ncentpoon: rev aa834a060ce9330e77ca81ad26f6a1aa74ff1427) * (add) phoenix-core/src/test/java/org/apache/phoenix/util/CoprocessorHConn= ectionTableFactoryTest.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/ServerUtil.java > Data table region should not close RS level shared/cached connections lik= e IndexWriter, RecoveryIndexWriter > -------------------------------------------------------------------------= ---------------------------------- > > Key: PHOENIX-4993 > URL: https://issues.apache.org/jira/browse/PHOENIX-4993 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.14.0 > Reporter: Kiran Kumar Maturi > Assignee: Kiran Kumar Maturi > Priority: Major > Fix For: 4.15.0, 5.1.0 > > Attachments: PHOENIX-4993-4.x-HBase-1.3.01.patch, PHOENIX-4993-4.= x-HBase-1.3.02.patch, PHOENIX-4993-4.x-HBase-1.3.03.patch, PHOENIX-4993-4.x= -HBase-1.3.04.patch, PHOENIX-4993-4.x-HBase-1.3.05.patch, PHOENIX-4993-mast= er.01.patch, PHOENIX-4993-master.02.patch > > > Issue is related to Region Server being killed when one region is closing= and another region is trying to write index updates. > When the data table region closes it will close region server level cache= d/shared connections and it could interrupt other region index/index-state = update. > -- Region1:=C2=A0Closing > {code:java} > TrackingParallellWriterIndexCommitter#stop() { > this.retryingFactory.shutdown(); > this.noRetriesFactory.shutdown(); > }{code} > closes the cached connections calling CoprocessorHConnectionTableFactory#= shutdown() in ServerUtil.java > =C2=A0 > --Region2: Writing index updates > Index updates fail as connections are closed, which leads to RejectedExec= utionException/Connection being null. This triggers=C2=A0PhoenixIndexFailur= ePolicy#handleFailureWithExceptions that tries to get the the syscat table = using the cached connections. Here it will not be able to reach to SYSCAT ,= so we will trigger KillServreFailurePolicy. > CoprocessorHConnectionTableFactory#getTable() > =C2=A0 > =C2=A0 > {code:java} > if (connection =3D=3D null || connection.isClosed()) { > throw new IllegalArgumentException("Connection is null or closed."); > }{code} > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)