From issues-return-3722-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org Thu Jan 3 04:32:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B963F18067A for ; Thu, 3 Jan 2019 04:32:04 +0100 (CET) Received: (qmail 62027 invoked by uid 500); 3 Jan 2019 03:32:03 -0000 Mailing-List: contact issues-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list issues@phoenix.apache.org Received: (qmail 62018 invoked by uid 99); 3 Jan 2019 03:32:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jan 2019 03:32:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0E30DCD1BD for ; Thu, 3 Jan 2019 03:32:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id eol83rKzcHzK for ; Thu, 3 Jan 2019 03:32:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A681460E56 for ; Thu, 3 Jan 2019 03:32:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1FE83E2635 for ; Thu, 3 Jan 2019 03:32:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6C2D1253EC for ; Thu, 3 Jan 2019 03:32:00 +0000 (UTC) Date: Thu, 3 Jan 2019 03:32:00 +0000 (UTC) From: "chenglei (JIRA)" To: issues@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4820) Optimize OrderBy for ClientAggregatePlan MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-4820?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16= 732622#comment-16732622 ]=20 chenglei commented on PHOENIX-4820: ----------------------------------- [~tdsilva]=EF=BC=8CI uploaded a new patch following your review and made a = few modification for {{BaseCompoundExpression}} and {{BaseExpression}} in o= rder to pass the UnitTests and IT tests, please help me have a review,thank= your very much. > Optimize OrderBy for ClientAggregatePlan > ---------------------------------------- > > Key: PHOENIX-4820 > URL: https://issues.apache.org/jira/browse/PHOENIX-4820 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 4.14.0 > Reporter: chenglei > Assignee: chenglei > Priority: Major > Fix For: 4.15.0 > > Attachments: PHOENIX-4820-4.x-HBase-1.3.patch, PHOENIX-4820.diff,= PHOENIX-4820_v2-4.x-HBase-1.3.patch > > > Given a table > {code} > create table test (=20 > pk1 varchar not null ,=20 > pk2 varchar not null,=20 > pk3 varchar not null, > v1 varchar,=20 > v2 varchar,=20 > CONSTRAINT TEST_PK PRIMARY KEY (=20 > pk1, > pk2, > pk3 )) > {code} > for following sql : > {code} > select a.ak3=20 > from (select substr(pk1,1,1) ak1,substr(pk2,1,1) ak2,substr(pk3,1,1)= ak3,substr(v1,1,1) av1,substr(v2,1,1) av2 from test order by pk2,pk3 limit= 10) a group by a.ak3,a.av1 order by a.ak3,a.av1 > {code} > Intuitively, the above OrderBy statement {{order by a.ak3,a.av1}} should = be compiled out because it match the group by statement, but in fact it is = not. > The problem is caused by the {{QueryCompiler.compileSingleQuery}} and {{Q= ueryCompiler.compileSingleFlatQuery}},for {{QueryCompiler.compileSingleQue= ry}} method,because the inner query has order by, so in line 520, local var= iable {{isInRowKeyOrder}} is false: > {code} > 519 context.setCurrentTable(tableRef); > 520 boolean isInRowKeyOrder =3D innerPlan.getGroupBy() =3D=3D Grou= pBy.EMPTY_GROUP_BY && innerPlan.getOrderBy() =3D=3D OrderBy.EMPTY_ORDER_BY; > {code} > In {{QueryCompiler.compileSingleFlatQuery}},when {{OrderByCompiler.compil= e}} method is invoked, the last parameter {{isInRowKeyOrder}} is false: > {code} > 562 OrderBy orderBy =3D OrderByCompiler.compile(context, select, g= roupBy, limit, offset, projector, > 563 groupBy =3D=3D GroupBy.EMPTY_GROUP_BY ? innerPlanTuple= Projector : null, isInRowKeyOrder); > {code} > So in following line 156 for {{OrderByCompiler.compile}},even though the= {{tracker.isOrderPreserving}} is true, the OrderBy statement could not be= compiled out. > {code} > 156 if (isInRowKeyOrder && tracker.isOrderPreserving()) { > {code} =20 > In my opinion, with GroupBy, in following line 563 for {{QueryCompiler.co= mpileSingleFlatQuery}} method, when we call=20 > {{OrderByCompiler.compile}} method, we no need to conside the {{isInRowKe= yOrder}}, just like the previous parameter {{tupleProjector}} does. > {code} > 562 OrderBy orderBy =3D OrderByCompiler.compile(context, select, = groupBy, limit, offset, projector, > 563 groupBy =3D=3D GroupBy.EMPTY_GROUP_BY ? innerPlanTupl= eProjector : null, isInRowKeyOrder); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)